On Thu, Mar 24, 2011 at 02:36:13PM +0530, Tushar Behera wrote: > On Samsung Kconfig files, HAVE_S3C2410_I2C is selected if we want > to enable support for I2C. But the I2C controller is selected only > if I2C_S3C2410 is defined. > > This patch selects I2C_S3C2410 when I2C and HAVE_S3C2410 are selected. No. Do not do this, just having the device on the board does not mean you want it forced into the kernel. A user may want to build it as a module or not build it at-all. -- Ben Dooks, ben@xxxxxxxxx, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html