Re: [PATCH 5/6] ARM: SAMSUNG: Add clkdev support for exynos4

Seungwhan Youn <claude.youn@xxxxxxxxx> · Sat, 19 Mar 2011 18:42:33 +0900

Hi,

On Sat, Mar 19, 2011 at 4:50 PM, Thomas Abraham <thomas.ab@xxxxxxxxxxx> wrote:
> Add clkdev support for Samsung's exynos4 platforms.
>
> Cc: Ben Dooks <ben-linux@xxxxxxxxx>
> Signed-off-by: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
> ---
> Âarch/arm/mach-exynos4/Kconfig Â Â Â Â Â Â Â | Â Â1 +
> Âarch/arm/mach-exynos4/clock.c Â Â Â Â Â Â Â | Â 57 +++++++++++++++++++++++++++
> Âarch/arm/mach-exynos4/include/mach/clkdev.h | Â Â7 +++
> Âarch/arm/mach-exynos4/time.c Â Â Â Â Â Â Â Â| Â Â2 +
> Âarch/arm/plat-samsung/pwm-clock.c Â Â Â Â Â | Â 10 +++++
> Â5 files changed, 77 insertions(+), 0 deletions(-)
> Âcreate mode 100644 arch/arm/mach-exynos4/include/mach/clkdev.h
>
> diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
> index a021b52..58451c3 100644
> --- a/arch/arm/mach-exynos4/Kconfig
> +++ b/arch/arm/mach-exynos4/Kconfig
> @@ -110,6 +110,7 @@ config MACH_SMDKC210
> Âconfig MACH_SMDKV310
> Â Â Â Âbool "SMDKV310"
> Â Â Â Âselect CPU_EXYNOS4210
> + Â Â Â select CLKDEV_LOOKUP

IMHO, 'clkdev' features, in this patch, seems to be applied to all
EXYNOS4 architecture, not to only SMDKV310 machine. So, I think that
this 'CLKDEV_LOOKUP' may be added into 'arch/arm/Kconfig', not this
file('arch/arm/mach-exynos4/Kconfig').

Something like belows...

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index eed07ea..1069dc1 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -768,6 +768,7 @@ config ARCH_EXYNOS4
        select ARCH_SPARSEMEM_ENABLE
        select GENERIC_GPIO
        select HAVE_CLK
+       select CLKDEV_LOOKUP
        select ARCH_HAS_CPUFREQ
        select GENERIC_CLOCKEVENTS
        select HAVE_S3C_RTC if RTC_CLASS


Thanks,
Claude
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html





