Hi Mark,
Thanks for your comments.
On 8 March 2011 17:07, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Mar 08, 2011 at 04:10:52PM +0530, Giridhar Maruthy wrote:
>
> > +#ifdef CONFIG_REGULATOR_WM8994
> > +static struct regulator_consumer_supply wm8994_fixed_voltage0_supplies[] = {
> > + {
> > + .dev_name = "1-001a",
> > + .supply = "AVDD2",
>
> This ifdef looks wrong - you're testing for the WM8994 regulators but
> the things inside the define are fixed voltage regulators. Probably
> best to just make the whole lot depend on CONFIG_REGULATOR and then
> select the regulator drivers if that's enabled:
>
> select REGULATOR_WM8994 if REGULATOR
> select REGULATOR_FIXED if REGULATOR
>
> (just doing Kconfig symbols from memory, I might be misremembering.)
>
Ok. I will move these configs to the Kconfig file[1] where we select
WM8994 codec.
Since WM8994 codec requires CONFIG_REGULATOR to be defined, would it
be appropriate to select REGULATOR also in [1] and remove the ifdef
CONFIG_REGULATOR?
[1] sound/soc/samsung/Kconfig
> > +#ifdef CONFIG_I2C_S3C2410
> > +#ifdef CONFIG_S3C_DEV_I2C1
>
> The above will break if someone builds I2C modular - there's a separate
> _MODULE define for that. Though TBH I'm not sure all this ifdefery is
> really buying much.
Yes, you are right. I will get rid of this ifdef.
Regards,
Giridhar
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
