On Thu, Mar 03, 2011 at 11:40:26AM +0900, Kyungmin Park wrote: > On Tue, Feb 15, 2011 at 8:35 PM, Russell King - ARM Linux > <linux@xxxxxxxxxxxxxxxx> wrote: > > On Tue, Feb 15, 2011 at 11:59:15AM +0100, Marek Szyprowski wrote: > >> #include <mach/map.h> > >> +#include <mach/gpio.h> > > > > Need I say anything about this? > > Hi Russell, > > How about to prevent it as compiler error? It's frequent mistake. > > At each mach/gpio.h > > #ifndef __LINUX_GPIO_H > #error "You should include <linux/gpio.h> instead of <mach/gpio.h>." > #endif It doesn't stop people including linux/gpio.h and then mach/gpio.h, which is also a common mistake. Besides, it's easy to catch when you have a regexp setup in your mail reader to find them... -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |