Dear Kukjin Kim,
2011-02-28 ìí 4:42, Kukjin Kim ì ê:
> Minkyu Kang wrote:
>>
>> This patch adds Samsung NURI board support.
>>
>> Signed-off-by: Minkyu Kang <mk7.kang@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>> ---
>> This patch is base on next-exynos4 branch at kgene tree.
>>
>> arch/arm/configs/exynos4_defconfig | 1 +
>> arch/arm/mach-exynos4/Kconfig | 15 +++
>> arch/arm/mach-exynos4/Makefile | 1 +
>> arch/arm/mach-exynos4/mach-nuri.c | 233
>> ++++++++++++++++++++++++++++++++++++
>> 4 files changed, 250 insertions(+), 0 deletions(-)
>> create mode 100644 arch/arm/mach-exynos4/mach-nuri.c
>>
>
>> +enum fixed_regulator_id {
>> + FIXED_REG_ID_MMC = 0,
>
> FIXED_REG_ID_MMC,
>
> (snip)
>
>> +static struct platform_device emmc_fixed_voltage = {
>> + .name = "reg-fixed-voltage",
>> + .id = FIXED_REG_ID_MMC,
>
> Is there any reason to use FIXED_REG_ID_MMC instead directly id 0?
>
I'm going to add more IDs of fixed regulator that are LCD and Backlight, and so on.
So use enum values for avoid the hard coding.
Thanks.
Minkyu Kang.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
