RE: [PATCH] ARM: S5PV210: Use REGULATOR_SUPPLY macro for regulator consumers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Friday, February 11, 2011 7:31 PM Mark Brown wrote:

> On Fri, Feb 11, 2011 at 10:31:08AM +0100, Marek Szyprowski wrote:
> 
> > I'm sorry for the late reply, just noticed this commit on your kernel tree...
> 
> Please don't make up e-mail addresses for people if you want them to see
> your e-mail - my e-mail address is broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx

I'm really sorry for the using wrong email. I've relied on email cache, but
it looks it was simply wrong here...

> > > -	.num_consumer_supplies	= ARRAY_SIZE(buck1_consumer),
> > > -	.consumer_supplies	= buck1_consumer,
> > > +	.num_consumer_supplies	= 1,
> > > +	.consumer_supplies	= &buck1_consumer,
> > >  };
> 
> > I'm really not sure that this type of change is necessary. IMHO it makes the code harder
> > to read, update or reuse. What is the reason for it?
> 
> FWIW I don't think it makes much difference either way.

Ok, then I'm fine with the change.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center


--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux