Hello, On Wednesday, December 22, 2010 12:55 PM Jeongtae Park wrote: > Multi Format Codec v5.1 is a module available on S5PC110 and S5PC210 > Samsung SoCs. Hardware is capable of handling a range of video codecs > and this driver provides V4L2 interface for video decoding & encoding. > > Reviewed-by: Peter Oh <jaeryul.oh@xxxxxxxxxxx> > Signed-off-by: Jeongtae Park <jtp.park@xxxxxxxxxxx> This patch is heavily based on the earlier patch posted by Kamil Debski. See http://permalink.gmane.org/gmane.linux.drivers.video-input-infrastructure/26316 However I see no credits for the original author in the patch header. Moreover, Jeongtae Park put himself as an author of this patch... This is a VERY BAD practice that shouldn't be accepted in the open source community. Dear Jeongtae Park, you should separate your work (encoding) from the work of others (I mean original patch posted by Kamil). You can achieve this by including the original patches (with all Signed-off-by lines) and add your incremental extensions to them. This way the author of each part will be credited correctly. This is very important for proper cooperation. Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html