On 01/12/10 11:55, Mark Brown wrote: > On Wed, Dec 01, 2010 at 08:44:25PM +0900, Kukjin Kim wrote: >> Mark Brown wrote: > >>> This makes all the functions that use the shift slightly smaller, one >>> instruction in most cases but more for ack() and maskack(). > >> Uhm...I'm not sure to use chip_data for the eint_irq_to_bit() is best to us. > > Could you elaborate on your concern here? I can't think of anything > else we might want to include in the data, and avoiding the shifts > and/or dereferences seems useful for anyone doing interrupt heavy work. Hi, post code to show difference in output would be good! -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html