Re: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices

[Jassi Brar <jassisinghbrar@xxxxxxxxx>]

On Fri, Dec 3, 2010 at 1:37 AM, Sylwester Nawrocki
<s.nawrocki@xxxxxxxxxxx> wrote:
> There may be up to 2 MIPI-CSI2 interfaces depending on SoC version.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> Âarch/arm/plat-s5p/Kconfig         |  10 ++++++++
> Âarch/arm/plat-s5p/Makefile        Â|  Â2 +
> Âarch/arm/plat-s5p/dev-csis0.c       |  34 +++++++++++++++++++++++++++++
> Âarch/arm/plat-s5p/dev-csis1.c       |  33 ++++++++++++++++++++++++++++
> Âarch/arm/plat-samsung/include/plat/csis.h | Â 28 +++++++++++++++++++++++
> Âarch/arm/plat-samsung/include/plat/devs.h | Â Â3 ++
> Â6 files changed, 110 insertions(+), 0 deletions(-)
> Âcreate mode 100644 arch/arm/plat-s5p/dev-csis0.c
> Âcreate mode 100644 arch/arm/plat-s5p/dev-csis1.c
> Âcreate mode 100644 arch/arm/plat-samsung/include/plat/csis.h
>
> diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig
> index 65dbfa8..2fb0c88 100644
> --- a/arch/arm/plat-s5p/Kconfig
> +++ b/arch/arm/plat-s5p/Kconfig
> @@ -56,3 +56,13 @@ config S5P_DEV_ONENAND
> Â Â Â Âbool
> Â Â Â Âhelp
> Â Â Â Â ÂCompile in platform device definition for OneNAND controller
> +
> +config S5P_DEV_CSIS0
> + Â Â Â bool
> + Â Â Â help
> + Â Â Â Â Compile in platform device definitions for MIPI-CSI2 interface 0
> +
> +config S5P_DEV_CSIS1
> + Â Â Â bool
> + Â Â Â help
> + Â Â Â Â Compile in platform device definitions for MIPI-CSI2 interface 1
> diff --git a/arch/arm/plat-s5p/Makefile b/arch/arm/plat-s5p/Makefile
> index de65238..2b73173 100644
> --- a/arch/arm/plat-s5p/Makefile
> +++ b/arch/arm/plat-s5p/Makefile
> @@ -28,3 +28,5 @@ obj-$(CONFIG_S5P_DEV_FIMC0) Â += dev-fimc0.o
> Âobj-$(CONFIG_S5P_DEV_FIMC1) Â Â+= dev-fimc1.o
> Âobj-$(CONFIG_S5P_DEV_FIMC2) Â Â+= dev-fimc2.o
> Âobj-$(CONFIG_S5P_DEV_ONENAND) Â+= dev-onenand.o
> +obj-$(CONFIG_S5P_DEV_CSIS0) Â Â+= dev-csis0.o
> +obj-$(CONFIG_S5P_DEV_CSIS1) Â Â+= dev-csis1.o

When we do have defines for each device, why not have both in one file
with each contained in ifdef for it's define ? That will reduce file count.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html