On Tuesday 30 November 2010 13:53:43 Lars-Peter Clausen wrote:
> > Hmm...how about s3c_gpio_setpull_1updown(...)?
> > And actually, not used 3rd argument, "pull" now.
> > I prefer follwoing.
>
> You need the 4th arguemnt, because the s3c2440 only supports pullups and
> the s3c2442 only supports pulldowns. So you want to return -EINVAL if
> somebody tries to set a pullup on a s3c2442 based board.
> Your proposed solution would return 0 and set a pulldown instead.
Well, at least it allows single-binary kernel for s3c24xx to exist. I think
it's OK, as setting pull{up,down} bit for any non S3C_GPIO_PULL_NONE arg
preserves semantics for all SoCs (s3c2410/s3c2440/s3c2442) by cost of not
handling errors. Anyway, who wants to call cfgpull with S3C_GPIO_PULL_DOWN on
s3c2410/s3c2440 or with S3C_GPIO_PULL_UP on s3c2442?
Regards
Vasily
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
