Sergei Shtylyov wrote: > > Hello. > Hi, > On 21-10-2010 12:04, Kukjin Kim wrote: > > > From: Daein Moon<moon9124@xxxxxxxxxxx> > > > This patch adds the s3c_gpio_getpull() API that has been missed in the > > plat-samsung/gpio-config.c and actullay there is its extern declaration > > in plat/gpio-cfg.h. > > > Signed-off-by: Daein Moon<moon9124@xxxxxxxxxxx> > > Cc: Ben Dooks<ben-linux@xxxxxxxxx> > > Signed-off-by: Kukjin Kim<kgene.kim@xxxxxxxxxxx> > > --- > > NOTE: > > - already issued about this > > > arch/arm/plat-samsung/gpio-config.c | 19 > +++++++++++++++++++ > > .../plat-samsung/include/plat/gpio-cfg-helpers.h | 6 ++++++ > > 2 files changed, 25 insertions(+), 0 deletions(-) > > > diff --git a/arch/arm/plat-samsung/gpio-config.c b/arch/arm/plat- > samsung/gpio-config.c > > index 8a37211..b732b77 100644 > > --- a/arch/arm/plat-samsung/gpio-config.c > > +++ b/arch/arm/plat-samsung/gpio-config.c > [...] > > diff --git a/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h > b/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h > > index 3e21c75..c417f85 100644 > > --- a/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h > > +++ b/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h > > @@ -42,6 +42,12 @@ static inline int s3c_gpio_do_setpull(struct > s3c_gpio_chip *chip, > > return (chip->config->set_pull)(chip, off, pull); > > } > > > > +static inline unsigned s3c_gpio_do_getpull(struct s3c_gpio_chip *chip, > > + unsigned int off) > > +{ > > + return (chip->config->get_pull)(chip, off); > > Parens are not necessary here. > Thanks for your pointing out :-) Will fix it. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html