Ben Dooks wrote:
>
> On 21/10/10 01:58, Kukjin Kim wrote:
> > From: Seungwhan Youn <sw.youn@xxxxxxxxxxx>
> >
> > This patch adds DMA operation clock which is disabled as default.
> >
> > Signed-off-by: Seungwhan Youn <sw.youn@xxxxxxxxxxx>
> > Acked-by: Jassi Brar <jassi.brar@xxxxxxxxxxx>
> > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> > ---
> > arch/arm/mach-s5p6442/clock.c | 28
> +++++++++++++++++++++++
> > arch/arm/mach-s5p6442/include/mach/regs-clock.h | 1 +
> > 2 files changed, 29 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-s5p6442/clock.c
b/arch/arm/mach-s5p6442/clock.c
> > index dcd20f1..16d6e7e 100644
> > --- a/arch/arm/mach-s5p6442/clock.c
> > +++ b/arch/arm/mach-s5p6442/clock.c
> > @@ -192,6 +192,11 @@ static struct clk clk_pclkd1 = {
> > .parent = &clk_hclkd1,
> > };
> >
> > +int s5p6442_clk_ip0_ctrl(struct clk *clk, int enable)
> > +{
> > + return s5p_gatectrl(S5P_CLKGATE_IP0, clk, enable);
> > +}
> > +
> > int s5p6442_clk_ip3_ctrl(struct clk *clk, int enable)
> > {
> > return s5p_gatectrl(S5P_CLKGATE_IP3, clk, enable);
> > @@ -335,6 +340,16 @@ void __init_or_cpufreq s5p6442_setup_clocks(void)
> > clk_pclkd1.rate = pclkd1;
> > }
> >
> > +static struct clk init_clocks_disable[] = {
> > + {
> > + .name = "pdma",
> > + .id = -1,
> > + .parent = &clk_pclkd1,
> > + .enable = s5p6442_clk_ip0_ctrl,
> > + .ctrlbit = (1 << 3),
> > + },
> > +};
> > +
> > static struct clk init_clocks[] = {
> > {
> > .name = "systimer",
> > @@ -393,10 +408,23 @@ static struct clk *clks[] __initdata = {
> >
> > void __init s5p6442_register_clocks(void)
> > {
> > + struct clk *clkptr;
> > + int i, ret;
> > +
> > s3c24xx_register_clocks(clks, ARRAY_SIZE(clks));
> >
> > s3c_register_clksrc(clksrcs, ARRAY_SIZE(clksrcs));
> > s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
> >
> > + clkptr = init_clocks_disable;
> > + for (i = 0; i < ARRAY_SIZE(init_clocks_disable); i++, clkptr++) {
> > + ret = s3c24xx_register_clock(clkptr);
> > + if (ret < 0) {
> > + printk(KERN_ERR "Fail to register clock %s (%d)\n",
> > + clkptr->name, ret);
> > + } else
> > + (clkptr->enable)(clkptr, 0);
> > + }
>
> how about using s3c_register_clocks and then s3c_disable_clocks() ?
Yeah, your suggestion is better to me also :-)
But I think other Samsung SoCs need it too..so I'd like to apply this now
then will update all regarding stuff for our Samsung SoCs soon..if you're
ok.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
