Jongsun Han wrote: > > Sangbeom Kim wrote: > > > > > > From: Jongpill Lee <boyko.lee@xxxxxxxxxxx> > > > > > > This patch adds GPIOlib support for S5PV310 and S5PC210. > > > > > > Signed-off-by: Jongpill Lee <boyko.lee@xxxxxxxxxxx> > > > Signed-off-by: Sangbeom Kim <sbkim73@xxxxxxxxxxx> > > > --- > > > NOTE: > > > This patch used mapped VA IO as GPIO virtual address. > > > because firstly other Samsung SoC's GPIO used same method. > > > and I think that it's better to keep the same method. > > > And ioremap also can be used for it. > > > But in the GPIO, there is no need to allocate VA area dynamically. > > > because GPIO can be used in any drivers anytime so it can't iounmap GPIO > > > VA area. > > > > > Ok... > > > > (snip) > > > > > #define MAX_COMBINER_NR 40 > > > > > > +#define S5P_IRQ_EINT_BASE > COMBINER_IRQ(MAX_COMBINER_NR, 0) > > > + > > > +#define S5P_EINT_BASE1 (S5P_IRQ_EINT_BASE + 0) > > > +#define S5P_EINT_BASE2 (S5P_IRQ_EINT_BASE + 16) > > > + > > > > Hmm... > > If you want to add external interrupt, should be changed NR_IRQS too. > > > > Will apply with fixing NR_IRQS. > > > > It seems that S5P_IRQ_EINT_BASE has wrong definition. I think...No! > S5P_IRQ_EINT_BASE has to be COMBINER_IRQ(MAX_COMBINER_NR - 1, 0). > Maybe you mean COMBINER_IRQ(MAX_COMBINER_NR - 1, 1)...because IRQ_EINT16_31 is COMBINER_IRQ(39, 0) Anyway in my opinion, each COMBINER_GROUP(x) can has 8 combined interrupts even though actually just used only 1. Therefore, to use next COMBINER_GROUP, so that COMBINER_GROUP(39) can use 8 interrupts like others is better. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |