Hi, I agree your approach, put the common features in common place. but Samsung maintainers insist put these at each machine file at current time. So move this to the each machines for their tastes. Thank you, Kyungmin Park On Wed, Oct 6, 2010 at 8:09 AM, Maurus Cuelenaere <mcuelenaere@xxxxxxxxx> wrote: > The only missing thing for SoC-wide suspend support, is a call to s3c_pm_init, > so add that. This was tested on a S3C6410 SmartQ 7. > > Signed-off-by: Maurus Cuelenaere <mcuelenaere@xxxxxxxxx> > --- > arch/arm/mach-s3c64xx/pm.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-s3c64xx/pm.c b/arch/arm/mach-s3c64xx/pm.c > index 79412f7..db292c9 100644 > --- a/arch/arm/mach-s3c64xx/pm.c > +++ b/arch/arm/mach-s3c64xx/pm.c > @@ -187,6 +187,9 @@ static int s3c64xx_pm_init(void) > pm_cpu_prep = s3c64xx_pm_prepare; > pm_cpu_sleep = s3c64xx_cpu_suspend; > pm_uart_udivslot = 1; > + > + s3c_pm_init(); > + > return 0; > } > > -- > 1.7.2.3 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html