On Thu, Sep 30, 2010 at 10:02:37AM -0700, Colin Cross wrote: > On Wed, Sep 29, 2010 at 4:58 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > > Kukjin Kim wrote: > >> > >> From: Changhwan Youn <chaos.youn@xxxxxxxxxxx> > >> > >> This patch updates CPU hotplug implementation to reduce CPU power > >> consumption > >> and will turn off the CPU power when CPU1 is unplugged while previous CPU > >> hotplug > >> used CPU idle. > >> This patch removes init memory freeing code to use CPU boot code when CPU1 > > is > >> plugged-in again and adds vfp_enable() call to allow to access CP10 and > > CP11. > >> > >> Signed-off-by: Changhwan Youn <chaos.youn@xxxxxxxxxxx> > >> Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > >> Cc: Russell King <rmk@xxxxxxxxxxxxxxxx> > > Cc: Tony Lindgren <tony@xxxxxxxxxxx> > > Cc: Colin Cross <ccross@xxxxxxxxxxx> > > Cc: Erik Gilling <konkers@xxxxxxxxxxx> > > Cc: Olof Johansson <olof@xxxxxxxxx> > > > > snip > > >> +#ifndef CONFIG_HOTPLUG_CPU > >> if (!machine_is_integrator() && !machine_is_cintegrator()) > >> totalram_pages += > > free_area(__phys_to_pfn(__pa(__init_begin)), > >> __phys_to_pfn(__pa(__init_end)), > >> "init"); > >> +#endif > >> } > >> > >> #ifdef CONFIG_BLK_DEV_INITRD > > I don't think this is necessary. Any symbol that is necessary for CPU > hotplug should be marked with __cpuinit instead of __init. The linker > script will put __cpuinit symbols outside the __init_begin - > __init_end section if CONFIG_HOTPLUG_CPU is enabled. That's the theory, but not everything required for a complete restart of a secondary CPU (iow, if it's powered off) is in the right section yet. I'll have patches hopefully tomorrow to address this. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |