On Fri, Sep 10, 2010 at 06:55:50PM +0900, Kukjin Kim wrote: > > +static struct fixed_voltage_config mmc2_fixed_voltage_config = { > > + .supply_name = "T_FLASH_EN", > > + .microvolts = 2800000, > > + .gpio = S5PV210_MP05(4), /* XM0ADDR_12 */ ... > > static void goni_setup_sdhci(void) > > { > > - gpio_request(GONI_EXT_FLASH_EN, "FLASH_EN"); > > - gpio_direction_output(GONI_EXT_FLASH_EN, 1); > > - > Why need above changes in this patch? > Others, looks ok. It looks like ownership of this GPIO has been transferred to the fixed voltage regulator added in the patch (though using the #define in the fixed voltage regulator platform data might be a good idea). -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html