On Fri, Sep 10, 2010 at 09:23:23AM +0200, Marek Szyprowski wrote: > +static struct regulator_consumer_supply goni_ldo5_consumers[] = { > + { .supply = "vmmc", .dev = &s3c_device_hsmmc0.dev }, > +}; > + This is OK but it is better to use dev_name rather than dev - dev may be removed at some point since given dev you can always use dev_name but you don't always have dev. Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html