Kyungmin Park wrote: > > Do you check the DVS feature? > It can support the DVS by GPIOs and platform can set the each voltages at > each mode. > Ok...I agree about the feature's necessity that you said. However, we don't need separate driver which has same/similar functionality. So...would be better that could implement it in max8649... Could you please do it based on this?...in fact, can't test it on SMDK. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > As quick review of max8649. It can't support it. > > Thank you, > Kyungmin Park > > -----Original Message----- > From: Kukjin Kim [mailto:kgene.kim@xxxxxxxxxxx] > Sent: Wednesday, September 08, 2010 8:26 AM > To: linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-samsung-soc@xxxxxxxxxxxxxxx > Cc: lrg@xxxxxxxxxxxxxxx; Changhwan Youn; Kukjin Kim; MyungJoo Ham; Kyungmin > Park > Subject: [PATCH v3] regulators: add support max8952 regulator > > From: Changhwan Youn <chaos.youn@xxxxxxxxxxx> > > The operation of max8952 is almost similar to max8649 except the output > voltage range. This patch adds support the max8952 regulator using > current max8649 implementation. And removes separate max8952.[ch] files > since the functionality is now merged into this driver. > > Signed-off-by: Changhwan Youn <chaos.youn@xxxxxxxxxxx> > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> > Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > Following is as per Mark Brown's suggestion. > Changes since v2: > - Removed separate max8952.[ch] files > > Changes since v1: > - Added returning fail when detected wrong ID > - Added matching the ID from the chip in case the user got things wrong > - Added enum chip ID instead of 0, 1 > (snip) -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |