Re: [PATCH 2/2] s3cmci: minor fixups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/09/10 16:16, Vasily Khoruzhick wrote:
> - It's not necessary to start DMA op manually, as we have
> autostart feature enabled
> - Restore prescaler before DMA operation, otherwise it
> takes ages to complete DMA op.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>
> ---
>  drivers/mmc/host/s3cmci.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
> index 2e16e0a..5d1a8ed 100644
> --- a/drivers/mmc/host/s3cmci.c
> +++ b/drivers/mmc/host/s3cmci.c
> @@ -1106,6 +1106,8 @@ static int s3cmci_prepare_dma(struct s3cmci_host *host, struct mmc_data *data)
>  		    sg_dma_address(&data->sg[i]),
>  		    sg_dma_len(&data->sg[i]));
>  
> +		/* Restore prescaler value */
> +		writel(host->prescaler, host->base + S3C2410_SDIPRE);
>  		res = s3c2410_dma_enqueue(host->dma, host,
>  					  sg_dma_address(&data->sg[i]),
>  					  sg_dma_len(&data->sg[i]));
> @@ -1116,8 +1118,6 @@ static int s3cmci_prepare_dma(struct s3cmci_host *host, struct mmc_data *data)
>  		}
>  	}
>  
> -	s3c2410_dma_ctrl(host->dma, S3C2410_DMAOP_START);
> -
>  	return 0;
>  }

looks ok to me.
Acked-By: Ben Dooks <ben-linux@xxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux