Em 02-08-2010 07:52, Russell King - ARM Linux escreveu: > On Mon, Aug 02, 2010 at 12:32:20PM +0200, Pawel Osciak wrote: >> Well, some of them are indeed unused, but it's not an uncommon practice in >> kernel and might help future developers. > > On the other hand, arch/arm is getting soo big that we need to do > something about this - and one solution is to avoid unnecessary > definitions that we're not using. > > Another good idea is to put definitions along side the drivers which > they're relevant to - maybe in a local driver-name.h file which > driver-name.c includes, or maybe even within driver-name.c if they're > not excessive. This has the advantage of distributing the "bloat" to > where its actually used, and means that the driver isn't dependent so > much on arch/arm or even the SoC itself. Very much appreciated from my side. It is very hard to sync changes that happen via arm trees when merging from my tree. There were several cases in the past were I needed to coordinate with an ARM maintainer about when he would merge from his tree, as the patches I had on media tree were highly dependent on the patches at arch. On several cases, I suspect that we had git bisect breakages (compilation or driver miss-functioning) due to those sync issues between two trees. A per-driver *.h file makes things easier, as such header file can be merged/maintained together with the subsystem tree where the driver belongs. > Take a look at arch/arm/mach-vexpress/include/mach/ct-ca9x4.h and > arch/arm/mach-vexpress/include/mach/motherboard.h - these are the only > two files which contain platform definitions which are actually used > for Versatile Express. Compare that with > arch/arm/mach-realview/include/mach/platform.h which contains lots > more... > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |