Wan ZongShun wrote: > > 2010/7/23 Kukjin Kim <kgene.kim@xxxxxxxxxxx>: > > Wan ZongShun wrote: > >> > >> 2010/7/21 Kukjin Kim <kgene.kim@xxxxxxxxxxx>: > >> > From: Taekgyun Ko <taeggyun.ko@xxxxxxxxxxx> > >> > > >> > RTC needs to be initialized when BCD registers have invalid value. > >> > >> Do you mean that the hardware register does not have default value? > >> Any results if no initialized value here? > >> > > Hi, > > > > Yes..I mean that it has no default value. > > As you know, it has to be keep the previous time value after reset..and the reset > value is not defined. > > > > So, reset is no use to this RTC BCD registers, it still keep previous > time value. > > > So added check that functionality, because if it has no valid BCD value, RTC > time does not move on. > > Of course, if we set time at that time, RTC works well...I mean just need initialize > that. > > > > Okay,good patch.:) > Thanks ;-) > In addtion,For making sure to get valid value, it is much better to > use also 'rtc_valid_tm(tm)' to check returning time value in your > s3c_rtc_gettime() and s3c_rtc_getalarm(() functions. > Ok..will do it later as per your suggestion. > > >> > > >> > Signed-off-by: Taekgyun Ko <taeggyun.ko@xxxxxxxxxxx> > >> > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > >> > --- > >> > drivers/rtc/rtc-s3c.c | 14 ++++++++++++-- > >> > 1 files changed, 12 insertions(+), 2 deletions(-) > >> > (snip) Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |