On Mon, Jul 19, 2010 at 05:30:34PM +0900, MyungJoo Ham wrote:
> +static int powerdomain_set(struct powerdomain *pd, int enable)
> +{
> + unsigned long ctrlbit;
> + void __iomem *reg;
> + void __iomem *stable_reg;
> + unsigned long reg_dat;
> +
> + if (pd == NULL)
> + return -EINVAL;
If someone calls this function with a NULL pd argument, is it better
to ignore it, or better to use WARN_ON and get a backtrace so it can
be fixed? I don't see much reason for this function to ever be called
with a NULL powerdomain argument.
> +
> + ctrlbit = pd->pd_ctrlbit;
> + reg = (void __iomem *)pd->pd_reg;
> + stable_reg = (void __iomem *)pd->pd_stable_reg;
Why not ensure that the element in the structure is correctly typed to
start with?
It's good practice to avoid casts whenever-possible - they hide bugs.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
