> -----Original Message----- > From: Maurus Cuelenaere [mailto:mcuelenaere@xxxxxxxxx] > Sent: Friday, July 16, 2010 3:36 PM > To: Sylwester Nawrocki > Cc: 'Kukjin Kim'; Pawel Osciak; Marek Szyprowski; > kyungmin.park@xxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux-samsung- > soc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 01/10 v2] ARM: Samsung: Add FIMC register and > platform definitions > > Op 16-07-10 15:30, Sylwester Nawrocki schreef: > > Hi, > > > > thank you for the review. Please se my comments below. > > > >> -----Original Message----- > >> From: Kukjin Kim [mailto:kgene.kim@xxxxxxxxxxx] > >> Sent: Friday, July 16, 2010 11:45 AM > >> To: 'Sylwester Nawrocki'; linux-samsung-soc@xxxxxxxxxxxxxxx; linux- > arm- > >> kernel@xxxxxxxxxxxxxxxxxxx > >> Cc: p.osciak@xxxxxxxxxxx; m.szyprowski@xxxxxxxxxxx; > >> kyungmin.park@xxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx > >> Subject: RE: [PATCH 01/10 v2] ARM: Samsung: Add FIMC register and > >> platform definitions > >> <snip> > >>> + > >>> +struct samsung_plat_fimc { > >>> + struct s3c_fifo_link *fifo_targets[FIMC_MAX_FIFO_TARGETS]; > >>> +}; > >>> + > >>> +#endif /* FIMC_H_ */ > >>> + > >> No need last empty line... > > C89 and C99 standard requires a new line character at the end of > file. > > The compiler should issue a warning when the new line character > > at the end of file is missing, otherwise it is not compliant with > > the above C standards. > > So I would rather add a new line where it is missing rather than > > removing it. > > There is lots of header files already in arch/arm/plat-samsung where > > there is even more than one empty line at the end of file. > > AFAIK there *already is* an empty line, git just omits it in diffs. > Try removing the last line with your editor and see what git diff > gives, it'll > show "\ No newline at end of file". Indeed, I just had two new-line characters with single empty line.. > > -- > Maurus Cuelenaere Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |