>Kukjin Kim <kgene.kim@xxxxxxxxxxx>: >Pawel Osciak wrote: >> >> From: Ben Dooks <ben-linux@xxxxxxxxx> >> >> As suggested by Marek Szyprowski, we should make the driver depend on >> the configuration currently being used to build the platform device >> into the kernel. >> >> Signed-off-by: Ben Dooks <ben-linux@xxxxxxxxx> >> Signed-off-by: Pawel Osciak <p.osciak@xxxxxxxxxxx> > >Actually, already submitted by Ben Dooks. >http://lists.infradead.org/pipermail/linux-arm-kernel/2010-May/015616.html > >So...I'm not sure adding your signedoff and re-submitting are right. > >In my opinion, it's enough to add comments which includes information about >that without re-submitting. > Adding signoffs is a normal procedure when submitting somebody else's patches with their permission. The problem here is that I wasn't aware of them being already posted, there must've been a miscommunication between me and Ben when I asked him if it was ok to submit his patches along with mine. Sorry Ben! Anyway, thank you for pointing this out. Of course, my sign-offs can be removed from the first 7 patches. Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center >> --- >> drivers/video/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >> index 3d94a14..858f1ca 100644 >> --- a/drivers/video/Kconfig >> +++ b/drivers/video/Kconfig >> @@ -1930,7 +1930,7 @@ config FB_TMIO_ACCELL >> >> config FB_S3C >> tristate "Samsung S3C framebuffer support" >> - depends on FB && ARCH_S3C64XX >> + depends on FB && S3C_DEV_FB >> select FB_CFB_FILLRECT >> select FB_CFB_COPYAREA >> select FB_CFB_IMAGEBLIT >> -- > >Thanks. > >Best regards, >Kgene. >-- >Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, >SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |