RE: [PATCH] ARM: S5P: Add PMU device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Maurus Cuelenaere wrote:
> 
>  Op 05-07-10 03:46, Joonyoung Shim schreef:
> > This patch adds an initcall for the s5p platforms so that they register
> > their PMU IRQs with the PMU framework in the Kernel.
> >
> > Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> > ---
> >  arch/arm/mach-s5p6442/include/mach/irqs.h |    2 +-
> >  arch/arm/mach-s5pc100/include/mach/irqs.h |    1 +
> >  arch/arm/mach-s5pv210/include/mach/irqs.h |    1 +
> >  arch/arm/plat-s5p/Makefile                |    1 +
> >  arch/arm/plat-s5p/dev-pmu.c               |   37
> +++++++++++++++++++++++++++++
> >  5 files changed, 41 insertions(+), 1 deletions(-)
> >  create mode 100644 arch/arm/plat-s5p/dev-pmu.c
> 
> Wouldn't it be better if this was in plat-samsung? I can see that the S3C6410
> datasheet mentions a PMU_IRQ_ENABLE bit in SYS_OTHERS so I suspect that it
> has
> the same functionality (even though there's no mention of which interrupt this
> is).
> 
Yes, I also found PMU_IRQ_ENABLE bit in System Others register of S3C6410 datasheet. But as your comments, could not found the interrupt number and any description...Actually, need to check whether it's available or not.

And S5P6440 has it.
So Joonyoung, it would be helpful if you could add 6440 PMUIRQ (VIC1[23]) in this patch.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux