Re: [PATCH v3 05/12] s3c-fb: Add support for display panning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pawel Osciak wrote:
> >Ben Dooks <ben@xxxxxxxxxxxx> wrote:
> >On 28/06/10 09:08, Pawel Osciak wrote:
> 
> >> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat-
> >samsung/include/plat/regs-fb.h
> >> index ac10013..f454e32 100644
> >> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h
> >> +++ b/arch/arm/plat-samsung/include/plat/regs-fb.h
> >> @@ -112,6 +112,11 @@
> >>  #define VIDCON2_ORGYCbCr			(1 << 8)
> >>  #define VIDCON2_YUVORDCrCb			(1 << 7)
> >>
> >> +/* PRTCON (S3C6410, S5PC100) */
> >
> >Not listed in my S3C6410 manual?
> >
> 
> Not in my either. It is there in the S5PC100 docs though. This is not an
> "official statement", but I've been testing panning on my 6410 *very*
> intensively and experienced a lot of crashes without it. Not a single one
> with it though. So it's either almost impossible luck or it is there,
> undocumented. There is a hole at this address anyway, so this shouldn't
> hurt anything.

Probably a good idea to put that in a comment, for the person who
looks at it in 5 years time and wonders if the code is mistaken.

-- Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux