Rabin Vincent wrote:
>
Hi Rabin,
Thanks for your comments. :-)
> On Fri, Jun 25, 2010 at 11:27:14PM +0900, Kukjin Kim wrote:
> > +static void s5pv310_pwm_init(unsigned int pwm_id, unsigned long tcnt)
> > +{
> > + unsigned long tcon;
> > +
> > + tcon = __raw_readl(S3C2410_TCON);
> > +
> > + /* timers reload after counting zero, so reduce the count by 1 */
> > + tcnt--;
> > +
> > + printk(KERN_DEBUG "timer tcon=%08lx, tcnt %08lx\n", tcon, tcnt);
>
> This function is called from set_event(). Do you really want this
> printk every time a tick is programmed?
>
Yeah, you're right.
Will modify it.
> > +static void __init s5pv310_clocksource_init(void)
> > +{
> > + unsigned long pclk;
> > + unsigned long clock_rate;
> > +
> > + pclk = clk_get_rate(timerclk);
> > +
> > + clk_set_rate(tdiv2, pclk / 2);
> > + clk_set_parent(tin2, tdiv2);
> > +
> > + clock_rate = clk_get_rate(tin2);
> > +
> > + pwm_clocksource.mult =
> > + clocksource_khz2mult(clock_rate/1000,
pwm_clocksource.shift);
> > +
> > + if (clocksource_register(&pwm_clocksource))
> > + panic("%s: can't register clocksource\n",
> pwm_clocksource.name);
> > +
> > + s5pv310_pwm_init(2, ~0);
> > + s5pv310_pwm_start(2, 1);
> > +}
> > +
>
> It would probably be prudent to start the clocksource before registering
> it, rather than after.
Oh, yes.
Will change it.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
