On Tue, Jun 01, 2010 at 05:16:33AM +0100, Ben Dooks wrote: > On Tue, Jun 01, 2010 at 12:23:39PM +0900, Kyungmin Park wrote: > > It's common function. Please add it to platform init instead of each board init. > I know Mark Brown would rather this be the case too, but the original intent > was that each board would declare itself to be capable of PM by calling this > function to ensure that any boards which had not been validated or where > simply incapable of suspend/resume did not end up with this enabled. This does result in rather confusing behaviour, in that the attempts to suspend end up getting silently ignored which isn't what you expect. Other ARM platforms deal with this by erroring out of the suspend if they can tell that it's not going to work and otherwise just trusting the system integrator to know what they're doing when they turn on suspend in Kconfig. It would be more friendly to at least put in a default implementation which prints an error telling the user what they need to do to actually get suspend working. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |