Hello, On Thursday, May 20, 2010 10:49 AM Ben Dooks wrote: > On Thu, May 20, 2010 at 08:59:05AM +0200, Marek Szyprowski wrote: > > This patch adds setup code for Samsung OneNAND controller driver. The > > driver needs to be aware on which SoC it is running, so the actual > > device id is being changed in cpu init code. S3C64xx SoCs have 2 OneNAND > > controllers while S5PC100 and S5PC110 has only one. > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > Ok, in future please try and keep a core and then have the architecture > additions seperate, it makes it very difficult to deal with any problems > whilst merging and means there is a higher possibility of a problem during > this. Ok, but I'm still not 100% sure how should I handle case like this properly. I thought that separating platform files from the driver itself would help merging it, because each part (the driver and platform setup code/register definitions) can be merged separately by the respective maintainers. Was it wrong that the platform patch was prepared for the tree after plat-s5pc1xx moves? Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html