Re: [PATCH 11/11] ARM: S5P6440: Remove redundant defines

[Jassi Brar <jassisinghbrar@xxxxxxxxx>]

On Thu, May 13, 2010 at 9:28 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> From: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
> --- a/arch/arm/mach-s5p6440/clock.c
> +++ b/arch/arm/mach-s5p6440/clock.c
> @@ -357,121 +357,121 @@ static struct clk init_clocks_disable[] = {
>                .id             = -1,
>                .parent         = &clk_hclk.clk,
>                .enable         = s5p6440_mem_ctrl,
> -               .ctrlbit        = S5P_CLKCON_MEM0_HCLK_NFCON,
> +               .ctrlbit        = (1 << 2),
Peculiar. I have never seen defines dropped in favor of magic numbers.
��.n��������+%������w��{.n�����{��Ʀ����)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥