On Tue, May 04, 2010 at 09:13:41AM +0200, christian pellegrin wrote: > On Tue, May 4, 2010 at 8:57 AM, Ben Dooks <ben-linux@xxxxxxxxx> wrote: > > > > please let me know why you feel the need to use test_and_set_bit on > > a variable that is single use. > > > > As I mentioned in the description the select function is not called in > a balanced way by upper layers, so there is a need to count it in the > driver (otherwise you end by calling clk_disable too many times if I > remember well). Perhaps the atomic operations are not needed but I'm > not sure about this so I preferred to take the cautionary approach (I > haven't studied if calls to select are serialized in the upper MTD > layer or even the block layer). Feel free to use a simple integer, but > I confirm that something like this patch is needed in 2.6.33 and > 2.6.34 if you want clock stopping enabled. I don't belive that atomic ops are needed, IIRC the mtd layer should sort that out. As such test_and_set_bit is hardly a count? > Thanks, > > -- > Christian Pellegrin, see http://www.evolware.org/chri/ > "Real Programmers don't play tennis, or any other sport which requires > you to change clothes. Mountain climbing is OK, and Real Programmers > wear their climbing boots to work in case a mountain should suddenly > spring up in the middle of the computer room." > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- -- Ben Q: What's a light-year? A: One-third less calories than a regular year. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |