jassi brar wrote: > On Fri, Mar 19, 2010 at 8:02 PM, Atul Dahiya <atul.dahiya@xxxxxxxxxxx> wrote: > > This patch adds DMA pl330 mico code for S5P series in plat-samsung.This patch > also > > moves some common code from s3c2410 to plat-samsung which can also be > used by pl330. > Not sure if it's a correct approach when the mainline discussions have > already made it clear that PL-330 > code shouldn't be Samsung specific. > Also, the samsung internal DMA driver style is needlessly borrowed > from s3c24xx dma. We don't > need that unnecessarily complicated state machine, though the API > should be kept. Hi jassi, I also agree your opinion. DMA PL330 can be used by other SoCs. So it has to be in the arch/arm/common/ or drivers/dma/. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html