On Tue, Mar 09, 2010 at 07:09:18PM +0530, Thomas Abraham wrote:
> +#ifdef CONFIG_MMC_SDHCI_S3C
> +int s5p_setup_sdhci_sclk(struct platform_device *pdev, struct clk *parent)
> +{
> + struct s3c_sdhci_platdata *pdata = pdev->dev.platform_data;
> + struct device *dev = &pdev->dev;
> + struct clk *sclk_mmc;
> +
> + sclk_mmc = clk_get(dev, "mmc_bus");
> + if (IS_ERR(sclk_mmc)) {
> + dev_err(dev, "failed to get mmc_bus clock\n");
> + return PTR_ERR(sclk_mmc);
> + }
There doesn't seem to be a matching clk_put for this.
> + sclk_mmc->ops->set_parent(sclk_mmc, parent);
Given that the user of this API needs to know enough about the clock
structure of the chip to know which parent clock to set (and already
have that parent clock) it's not clear to me what this API is intended
to do - as far as I can see it would live as well in the SDHCI driver as
it is at present.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
