On Mon, Mar 08, 2010 at 05:14:05PM +0100, christian pellegrin wrote: > On Mon, Mar 8, 2010 at 4:55 PM, Ben Dooks <ben-linux@xxxxxxxxx> wrote: > > > > Still not getting why you're changing this from x, to x - 1. > > > > ok: the reason is that gpio_nr is already incremented by one in the > for instruction. So gpio_nr is not pointing to the first pin of a bank > after the first iteration. Of course this doesn't matter because we > don't have 32 banks of gpio pins and s3c_gpiolib_getchip works even if > we point to a pin in the middle of a bank. But if we get a s3c device > with more than 32 banks the 33rd will be skipped. Or at least this is > the reason why I did this, maybe I'm mistaken. > > Anyway this is a minor point, I fixed it when catching why bank H was > not preserved (and so my serial console ttyS1 was dead). Can we have that as a seperate patch with that information in it, to show what is being changed. Thanks. -- Ben Q: What's a light-year? A: One-third less calories than a regular year. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |