On Thu, Jan 28, 2010 at 1:08 PM, jassi brar <jassisinghbrar@xxxxxxxxx> wrote: > On Thu, Jan 28, 2010 at 12:41 PM, Ben Dooks <ben@xxxxxxxxxxxxxxxxx> wrote: >> On Wed, Jan 27, 2010 at 02:59:29PM +0900, jassisinghbrar@xxxxxxxxx wrote: >>> From: Jassi Brar <jassi.brar@xxxxxxxxxxx> >>> >>> Add AC97 controller to platform devices and initialize the AC97 gpios. >> >> I'd much rather see platform devices always added unless there is a really >> good reason not to. People can build things as modules and this means you >> end up having to rebuild the core kernel as well as the module if you want >> to change. > Yes, sounds good to me. I will revise this patch accordingly. > Thanks s3c64xx_device_ac97 device is exported from dev-audio.c which is compiled only if CONFIG_SND_S3C24XX_SOC is defined. So, If we unconditionally add the platform device, it will give error in case the user didn't select Samsung ASoC option. So, I guess i should make it conditional on CONFIG_SND_S3C24XX_SOC rather than CONFIG_SND_SOC_SMDK_WM9713 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |