On Fri, Jan 15, 2010 at 07:52:10PM +0900, Kukjin Kim wrote: > This patch moves GPIO common functions (from plat-s3c64xx) into plat-samsung. > and adds the config option to build the plat-samsung/gpiolib for Samsung SoCs. > > Changes since v1: > > Address comments from Ben > > Signed-off-by: Aditya Pratap Sharma <adityaps@xxxxxxxxxxx> > Signed-off-by: Atul Dahiya <atul.dahiya@xxxxxxxxxxx> > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > --- > arch/arm/plat-s3c/include/plat/gpio-core.h | 3 + > arch/arm/plat-s3c64xx/Kconfig | 1 + > arch/arm/plat-s3c64xx/gpiolib.c | 162 +---------------------- > arch/arm/plat-samsung/Kconfig | 7 + > arch/arm/plat-samsung/Makefile | 1 + > arch/arm/plat-samsung/gpiolib.c | 202 ++++++++++++++++++++++++++++ > 6 files changed, 216 insertions(+), 160 deletions(-) > create mode 100644 arch/arm/plat-samsung/gpiolib.c We add CONFIG_SAMSUNG_GPIOLIB in this patch to indicate our support for the moved gpiolib code, however this code is only dealing with the case where we have 4bit control registers, the code to deal with the 2bit case is still in arch/arm/plat-s3c/gpio.c along with some other common functionality. I'm just wondering whether to ask for SAMSUNG_GPIOLIB to be renamed to SAMSUNG_GPIOLIB_4BIT or leave this for the moment as the older code is being implicity compiled so could be simply moved from the arch/arm/plat-s3c to arch/arm/plat-samsung easily. -- Ben -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |