On Tue, Jan 12, 2010 at 11:50:19PM +0000, Ben Dooks wrote: > On Tue, Jan 12, 2010 at 10:48:34PM +0000, Mark Brown wrote: > > I don't understand what the problem is with that? That's exactly what > > I'd expect to see a driver doing (possibly with NULL instead of a > > specific name). > From what I've looked at, the driver _should_ use clk_get(dev, NULL) for > the bus clock, and use named clocks only for extra clocks it may need > such as a codec clock for an audio device. I belive this is what Russell's > initial complaint about the implementation is. AFAICT that's a relatively cosmetic issue, but I don't know how Russell feels about that one. If the block has multiple clocks it can actually get a bit confusing trying to remember what the default clock should be. The issues I've noticed have been that at the minute the lookups are essentially using a global namespace for the clocks (since the only bit of the struct device that gets looked at when doing lookups is the id field) and that the muxes for clock sources are handled in individual drivers (which means the drivers need to know about the clock tree of the SoC they're running on). Given the way the Samsung SoCs structure their clock trees the name issue isn't quite so pressing as it might be, it'd probably only really bite if Samsung decide to change the names of the clocks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |