RE: [PATCH 1/7] ARM: S5P6440: Kconfigs and Makefiles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 11, 2009 at 22:30 +0900, jassi brar wrote:
> On Fri, Dec 11, 2009 at 6:52 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> > This patch adds Kconfigs and Makefiles for S5P6440.
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> > Signed-off-by: Adityapratap Sharma <aditya.ps@xxxxxxxxxxx>
> > Signed-off-by: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
> > Signed-off-by: Atul Dahiya <atul.dahiya@xxxxxxxxxxx>
> > ---
> >  arch/arm/Kconfig                    |   14 ++++++++++++-
> >  arch/arm/Makefile                   |    2 +
> >  arch/arm/mach-s5p6440/Kconfig       |   21 ++++++++++++++++++++
> >  arch/arm/mach-s5p6440/Makefile      |   19 ++++++++++++++++++
> >  arch/arm/mach-s5p6440/Makefile.boot |    2 +
> >  arch/arm/plat-s5p/Kconfig           |   36
> +++++++++++++++++++++++++++++++++++
> >  arch/arm/plat-s5p/Makefile          |   25 ++++++++++++++++++++++++
> >  7 files changed, 118 insertions(+), 1 deletions(-)
> >  create mode 100644 arch/arm/mach-s5p6440/Kconfig
> >  create mode 100644 arch/arm/mach-s5p6440/Makefile
> >  create mode 100644 arch/arm/mach-s5p6440/Makefile.boot
> >  create mode 100644 arch/arm/plat-s5p/Kconfig
> >  create mode 100644 arch/arm/plat-s5p/Makefile
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 78b6060..c9cb8ee 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -588,6 +588,13 @@ config ARCH_S3C64XX
> >        help
> >          Samsung S3C64XX series based systems
> >
> > +config ARCH_S5P6440
> > +       bool "Samsung S5P6440"
> > +       select GENERIC_GPIO
> > +       select HAVE_CLK
> > +       help
> > +         Samsung S5P6440 CPU based systems
> > +
> >  config ARCH_S5PC1XX
> >        bool "Samsung S5PC1XX"
> >        select GENERIC_GPIO
> > @@ -707,6 +714,7 @@ source "arch/arm/plat-samsung/Kconfig"
> >  source "arch/arm/plat-s3c24xx/Kconfig"
> >  source "arch/arm/plat-s3c64xx/Kconfig"
> >  source "arch/arm/plat-s3c/Kconfig"
> > +source "arch/arm/plat-s5p/Kconfig"
> >  source "arch/arm/plat-s5pc1xx/Kconfig"
> Issue of s5p64xx hogging namespace might arise for s5pc1xx.
> (s5p ought to be inclusive to s5pc1xx too, not just s5p64xx)
Yes, you’re right. As you mentioned plat-s5p can support all s5p series. Although current plat-s5p is for s5p6440, but the common plat code of all s5p series will be included there. Of course, all Samsung SoCs' common plat code will be included to plat-samsung.


> >  if ARCH_S3C2410
> > @@ -723,6 +731,10 @@ source "arch/arm/mach-s3c6400/Kconfig"
> >  source "arch/arm/mach-s3c6410/Kconfig"
> >  endif
> >
> > +if ARCH_S5P6440
> > +source "arch/arm/mach-s5p6440/Kconfig"
> > +endif
> > +
> >  source "arch/arm/plat-stmp3xxx/Kconfig"
> >
> >  if ARCH_S5PC1XX
> > @@ -1005,7 +1017,7 @@ config PREEMPT
> >  config HZ
> >        int
> >        default 128 if ARCH_L7200
> > -       default 200 if ARCH_EBSA110 || ARCH_S3C2410
> > +       default 200 if ARCH_EBSA110 || ARCH_S3C2410 || ARCH_S5P6440
> >        default OMAP_32K_TIMER_HZ if ARCH_OMAP && OMAP_32K_TIMER
> >        default AT91_TIMER_HZ if ARCH_AT91
> >        default 100
> > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > index a026565..376da2b 100644
> > --- a/arch/arm/Makefile
> > +++ b/arch/arm/Makefile
> > @@ -151,6 +151,7 @@ machine-$(CONFIG_ARCH_S3C2410)              :=
> s3c2410 s3c2400 s3c2412 s3c2440 s3c2442 s3c24
> >  machine-$(CONFIG_ARCH_S3C24A0)         := s3c24a0
> >  machine-$(CONFIG_ARCH_S3C64XX)         := s3c6400 s3c6410
> >  machine-$(CONFIG_ARCH_S5PC1XX)         := s5pc100
> > +machine-$(CONFIG_ARCH_S5P6440)         := s5p6440
> >  machine-$(CONFIG_ARCH_SA1100)          := sa1100
> >  machine-$(CONFIG_ARCH_SHARK)           := shark
> >  machine-$(CONFIG_ARCH_STMP378X)                := stmp378x
> > @@ -170,6 +171,7 @@ plat-$(CONFIG_PLAT_PXA)             := pxa
> >  plat-$(CONFIG_PLAT_S3C24XX)    := s3c24xx s3c samsung
> >  plat-$(CONFIG_PLAT_S3C64XX)    := s3c64xx s3c samsung
> >  plat-$(CONFIG_PLAT_S5PC1XX)    := s5pc1xx s3c samsung
> > +plat-$(CONFIG_PLAT_S5P)                := s5p samsung s3c
> 
> ^^^^^^^^^^^^^^^^^
> Nitpicking :)   Why not play along?        := s5p s3c samsung
Hmm...Soon plat-s5p may not need the codes of plat-s3c. So, I expressed so.


> >  plat-$(CONFIG_ARCH_STMP3XXX)   := stmp3xxx
> >
> >  ifeq ($(CONFIG_ARCH_EBSA110),y)
> > diff --git a/arch/arm/mach-s5p6440/Kconfig b/arch/arm/mach-s5p6440/Kconfig
> > new file mode 100644
> > index 0000000..421546b
> > --- /dev/null
> > +++ b/arch/arm/mach-s5p6440/Kconfig
> > @@ -0,0 +1,21 @@
> > +# arch/arm/mach-s5p6440/Kconfig
> > +#
> > +# Copyright (c) 2009 Samsung Electronics
> > +#              http://www.samsung.com/
> > +#
> > +# Licensed under GPLv2
> > +
> > +# Configuration options for the S5P6440 CPU
> > +
> > +config CPU_S5P6440
> > +       bool
> > +       select CPU_S5P6440_INIT
> > +       select CPU_S5P6440_CLOCK
> > +       help
> > +         Enable S5P6440 CPU support
> > +
> > +config MACH_SMDK6440
> > +       bool "SMDK6440"
> > +       select CPU_S5P6440
> > +       help
> > +         Machine support for the Samsung SMDK6440
> > diff --git a/arch/arm/mach-s5p6440/Makefile b/arch/arm/mach-s5p6440/Makefile
> > new file mode 100644
> > index 0000000..272e2b2
> > --- /dev/null
> > +++ b/arch/arm/mach-s5p6440/Makefile
> > @@ -0,0 +1,19 @@
> > +# arch/arm/mach-s5p6440/Makefile
> > +#
> > +# Copyright (c) 2009 Samsung Electronics
> > +#              http://www.samsung.com/
> > +#
> > +# Licensed under GPLv2
> > +
> > +obj-y                          :=
> > +obj-m                          :=
> > +obj-n                          :=
> > +obj-                           :=
> > +
> > +# Core support for S5P6440 system
> > +
> > +obj-$(CONFIG_CPU_S5P6440)      += cpu.o
> > +
> > +# machine support
> > +
> > +obj-$(CONFIG_MACH_SMDK6440)    += mach-smdk6440.o
> Shouldn't machine support come separate?
I'm sorry that because of relativity between patch files, I couldn't separate patch files so.


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
System LSI Division, SAMSUNG ELECTRONICS CO., LTD.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux