On Wed, Nov 18, 2009 at 11:14:52PM +0900, jassi brar wrote: > On Wed, Nov 18, 2009 at 10:33 PM, Marek Szyprowski > <m.szyprowski@xxxxxxxxxxx> wrote: > > From: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > > > Samsung S5PC110 SoCs have UART that differs a bit from the one known > > from the previous Samsung SoCs. This patch adds support for this new > > driver. > > > > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > Not just about this c110 patch: I think this string comparison thing > isn't very neat. > I think we'd better be doing it by indexing into an array of clock > names(which can be > defined in some platform specific code). I don't mind changing to using a table, but the table is probably best off here, closest to the UART drivers in question. -- Ben Q: What's a light-year? A: One-third less calories than a regular year. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |