On Tue, Oct 13, 2009 at 10:11:13AM +0200, Marek Szyprowski wrote:
> Add CPU idle support by a call to SoC build-in power management core.
> Add system reset support by a simple write to system controll register.
looks great, and is definitely an improvement.
However, one small comment:
> static void arch_reset(char mode, const char *cmd)
> {
> - /* nothing here yet */
> -}
> + unsigned long reset;
>
> + reset = 0xc100;
> + __raw_writel(reset, S5PC1XX_VA_CLK_OTHER);
> + return;
> +}
why do we first define an unsigned long reset and then set it to some magic
value? why not simply make this one line like
__raw_writel(0xc100, S5PC1XX_VA_CLK_OTHER);
also, it might be a good idea to use some #define values rather than the 0xc100
magic value.
--
- Harald Welte <laforge@xxxxxxxxxxxx> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
