On Wed, Nov 04, 2009 at 05:27:44PM +0900, jassisinghbrar@xxxxxxxxx wrote: > From: Jassi Brar <jassi.brar@xxxxxxxxxxx> > > Acting upon the inputs given by Mark and Ben, I have revised the code. > A few points to be noted:- > > 1) The prefix s3c24xx_pcm_ in the platform driver has been changed to > more neutral s3c_audio_ Not a fan of renaming, but I suppose this has some merit. I'll make some comments about this in the series, I think life could be made enater if some of these are cleaned up. It may be worth opening a discussion on the alsa list about renaming the entire directory to samsung instead of s3c. > 2) ALSA platform driver s3c24xx-pcm.c/h have been renamed s3c-audio.c/h > since the 'pcm' part will cause ambiguity once PCM Controller driver > is added. Also, since it is not just for 24xx, the part is dropped > from the prefix. > Ofcourse, evey dependent code has been modified to include differently > named, otherwise same, header s3c-audio.h ok. > 3) arch/arm/plat-s3c/include/plat/audio.h has been restored by with only > necessary data structures. > Having callbacks to configure controller pins appropriately is necessary > if the driver is to handle more than one SoC type. > Currently only callback to configure gpios has been defined, the data > structure will grow as and when needed. This seems ok, the old one wasn't being used. > 4) The PCM controller platform devices have been defined in the apparently > common arch/arm/plat-s3c64xx/dev-audio.c rather than a new PCM specific one. This'll be shaken up by my dev changes... will try and take into account of these patches before this change is done. > 5) Here comes the tricky one. > Breaking away from S3C convention, I have defined PCM controller register > offsets and bit fields in sound/soc/s3c24xx/s3c-pcm.h instead of some > platform/arch specific header. > The reason for the move is that usually the device controllers depend upon > platform type only as far as their base mapping address goes. Otherwise > just one or two 'types' of same devices serve most SoCs. > Having those definitions besides the driver helps avoid copyng the same > definitions for each platform that essentially have the same device controller. I'll have a look at that one. Can you ensure that you send patches with rename detection enabled, it would make it easier working out what has been changed. -- Ben Q: What's a light-year? A: One-third less calories than a regular year. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |