Re: [PATCH] S3C: ide: Add Samsung S3C IDE controller driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu,  8 Oct 2009 15:59:28 +0900
thomas.ab@xxxxxxxxxxx wrote:

> +irqreturn_t s3c_irq_handler(int irq, void *dev_id)
> +{
> +	ide_hwif_t *hwif = (ide_hwif_t *)dev_id;
> +	struct s3c_ide_device *ide_dev =
> +			(struct s3c_ide_device *)hwif->hwif_data;
> +	u32 reg = ide_readl(S3C_ATA_IRQ);
> +
> +	ide_writel(reg, S3C_ATA_IRQ);
> +	return ide_intr(irq, dev_id);
> +}

On top of what Jassi already mentioned, please make this static.

	M.
-- 
Fast. Cheap. Reliable. Pick two.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux