On Mon, Mar 10, 2025, at 11:49, Heiko Carstens wrote: > On Mon, Mar 10, 2025 at 11:26:57AM +0100, Thomas Huth wrote: > > Did this cause any sorts of problems? I can see this pattern all over > the place, so why is this now a problem? > > Also, wouldn't it be better to fix this with an sed statement in > scripts/headers_install.sh instead? Otherwise this is going to be a > never ending story since those things will be re-introduced all the > time. It should certainly be done in a consistent way across all architectures and architecture-independent headers. I see that all uapi headers use __ASSEMBLY__ consistently, while a few non-uapi headers use __ASSEMBLER__. glibc obviously defines __ASSEMBLY__ whenever it includes one of the kernel headers that need this from a .S file. Unless there is a known problem with the current code, leaving this unchanged is probably the least risky way. Arnd
