Re: [RFC net-next 5/7] net/ism: Move ism_loopback to net/ism

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06.02.25 18:36, Julian Ruess wrote:
>> +static int ism_lo_query_rgid(struct ism_dev *ism, uuid_t *rgid,
>> +			     u32 vid_valid, u32 vid)
>> +{
>> +	/* rgid should be the same as lgid; vlan is not supported */
>> +	if (!vid_valid && uuid_equal(rgid, &ism->gid))
>> +		return 0;
>> +	return -ENETUNREACH;
>> +}
> This vid_valid check breaks ism-loopback for me.


oops, I also get:
> smc_chk -C 10.44.30.50
[1] 967189
Test with target IP 10.44.30.50 and port 37373
  Live test (SMC-D and SMC-R)
Server started on port 37373
     Failed  (TCP fallback), reasons:
          Client:        0x05000000   Peer declined during handshake
          Server:        0x03030007   No SMC-Dv2 device found, but required

Sorry about that.
Current upstream smc_loopback just ignores vid_valid in smc_lo_query_rgidsmc_lo_query_rgid(),
but I'm not sure that is the best way to handle that.
I'll investigate and make sure it works in v2.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux