On Thu, Jan 30, 2025 at 12:37:13PM +0100, Alexander Gordeev wrote: > On Thu, Jan 30, 2025 at 11:46:15AM +0100, Halil Pasic wrote: > > > > I'm not sure I understand the value of this. What we have here is not > > > > a flexible array but a one element array. Something that in the generic > > > > case could be many but particularly for vfio-ap is always one. > > > > > > You are correct. Only fake flexible arrays should be transformed into > > > C99 flex-array members [1]. > > > > > > Thanks > > > -Gustavo > > > > > > [1] https://lwn.net/Articles/908817/ > > > > > > > Thanks! Alex, what do we do with this then? I think you picked it up > > yesterday late. And I think, it might make sense to make this look > > less like a fake flex-array... > > Dropped. > Thanks for looking into it! Given that we already have 5dd4241964c8 ("vfio/ccw: replace one-element array with flexible-array member") applied, we now end up with inconsistent code. I'd prefer if we address _both_ code locations in a way that the code looks similar, and people won't send similar patches again and again. Halil, since you started this discussion, can you address this please?
