On 19/12/2024 18:13, Dave Hansen wrote: > On 12/19/24 08:44, Kevin Brodsky wrote: >> +---------------+-------------------------+-----------------------+--------------+------------------------------------+ >> | x86 | Y | Y | Y/N | kmem_cache at pgd level if PAE | >> +---------------+-------------------------+-----------------------+--------------+------------------------------------+ > This is a really rare series that adds functionality _and_ removes code > overall. It looks really good to me. The x86 implementation seems to be > captured just fine in the generic one: Thank you for the review, very appreciated! > Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> Just to double-check, are your ack'ing the x86 changes specifically? If so I'll add your Acked-by on patch 6, 7 and 9. > One super tiny nit is that the PAE pgd _can_ be allocated using > __get_free_pages(). It was originally there for Xen, but I think it's > being used for PTI only at this point and the comments are wrong-ish. > > I kinda think we should just get rid of the 32-bit kmem_cache entirely. That would certainly simplify things on the x86 side! I'm not at all familiar with that code though, would you be happy with providing a patch? I could add it to this series if that's convenient. - Kevin
