On 12/9/2024 10:19 AM, Jason Gunthorpe wrote:
On Tue, Dec 03, 2024 at 10:41:58AM -0800, Ramesh Thomas wrote:
Remove the #ifdef iowrite64 and #ifdef ioread64 checks around calls to
64 bit IO access. Since default implementations have been enabled, the
checks are not required. Such checks can hide potential bugs as well.
Instead check for CONFIG_64BIT to make the 64 bit IO calls only when 64
bit support is enabled.
Why?
The whole point of the emulation header to to avoid this?
I think you would just include the header and then remove the ifdef
entirely. Instead of vfio doing memcpy with 32 bit it will do memcpy
internally to the io accessors?
There is nothing about this that has to be atomic or something.
Ok, I will send a new patch series that only removes the check for
ioread64 and iowrite64.
Thanks,
Ramesh
