Re: [PATCH 5/5] scsi: arcmsr: Use BIN_ATTR_ADMIN_WO() for bin_attribute definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 5/5] scsi: arcmsr: Use BIN_ATTR_ADMIN_WO() for bin_attribute definitions
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 04 Dec 2024 14:56:18 -0500
Cc: Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Naveen N Rao <naveen@xxxxxxxxxx>, Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>, Tzung-Bi Shih <tzungbi@xxxxxxxxxx>, Brian Norris <briannorris@xxxxxxxxxxxx>, Julius Werner <jwerner@xxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, chrome-platform@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx
In-reply-to: <20241202-sysfs-const-bin_attr-admin_wo-v1-5-f489116210bf@weissschuh.net> ("Thomas Weißschuh"'s message of "Mon, 02 Dec 2024 20:00:40 +0100")
Organization: Oracle Corporation
References: <20241202-sysfs-const-bin_attr-admin_wo-v1-0-f489116210bf@weissschuh.net> <20241202-sysfs-const-bin_attr-admin_wo-v1-5-f489116210bf@weissschuh.net>

Thomas,

> Using the macro saves some lines of code and prepares the attributes for
> the general constifications of struct bin_attributes.
>
> While at it also constify the callback parameters.

Looks OK to me.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH 0/5] sysfs: introduce and use macro BIN_ATTR_ADMIN_WO()
  - From: Thomas Weißschuh
- [PATCH 5/5] scsi: arcmsr: Use BIN_ATTR_ADMIN_WO() for bin_attribute definitions
  - From: Thomas Weißschuh

Prev by Date: Re: s390: block/blk-iocost.c:1101:11: error: call to '__compiletime_assert_557' declared with 'error' attribute: clamp() low limit 1 greater than high limit active
Next by Date: Re: [PATCH net-next v2 0/2] net/smc: Two features for smc-r
Previous by thread: [PATCH 5/5] scsi: arcmsr: Use BIN_ATTR_ADMIN_WO() for bin_attribute definitions
Next by thread: Re: [PATCH 5/5] scsi: arcmsr: Use BIN_ATTR_ADMIN_WO() for bin_attribute definitions
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite Info] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Linux Media] [Device Mapper]