On 31.10.24 11:01, Paolo Abeni wrote:
On 10/25/24 09:23, Wenjia Zhang wrote:Commit c2261dd76b54 ("RDMA/device: Add ib_device_set_netdev() as an alternative to get_netdev") introduced an API ib_device_get_netdev. The SMC-R variant of the SMC protocol continued to use the old API ib_device_ops.get_netdev() to lookup netdev. As this commit 8d159eb2117b ("RDMA/mlx5: Use IB set_netdev and get_netdev functions") removed the get_netdev callback from mlx5_ib_dev_common_roce_ops, calling ib_device_ops.get_netdev didn't work any more at least by using a mlx5 device driver. Thus, using ib_device_set_netdev() now became mandatory. Replace ib_device_ops.get_netdev() with ib_device_get_netdev(). Fixes: 54903572c23c ("net/smc: allow pnetid-less configuration") Fixes: 8d159eb2117b ("RDMA/mlx5: Use IB set_netdev and get_netdev functions") Reported-by: Aswin K <aswin@xxxxxxxxxxxxx> Reviewed-by: Gerd Bayer <gbayer@xxxxxxxxxxxxx> Signed-off-by: Wenjia Zhang <wenjia@xxxxxxxxxxxxx>Please adjust the commit message as per Leon suggestion. You can retain all the ack collected so far. Thanks, Paolo
Hi Paolo, thank you for the reminder! Sure, I'll do it. Thanks, Wenjia
