On 23.10.24 14:12, Alexander Egorenkov wrote:
Hi David,
David Hildenbrand <david@xxxxxxxxxx> writes:
Similarly provide a custom is_kdump_kernel() implementation that will only
return "true" in kdump environments, and will do so consistently during
boot.
Update the documentation of is_dump_available().
A small typo here:
is_dump_available() -> dump_available()
@@ -587,16 +587,16 @@ int smp_store_status(int cpu)
* with sigp stop-and-store-status. The firmware or the boot-loader
* stored the registers of the boot CPU in the absolute lowcore in the
* memory of the old system.
- * 3) kdump and the old kernel did not store the CPU state,
- * or stand-alone kdump for DASD
- * condition: OLDMEM_BASE != NULL && !is_kdump_kernel()
+ * 3) kdump or stand-alone kdump for DASD
+ * condition: OLDMEM_BASE != NULL && !is_ipl_type_dump() == false
Here is a typo in the condition, a redundant '!' before is_ipl_type_dump().
Thanks for catching these! Too much going back and forth ... :)
Otherwise, looks very good to me.
Thanks for the fast review. I assume these can be fixed up when
applying. But please let me know if a v3 is preferred, and I can send
one after waiting a couple of days.
--
Cheers,
David / dhildenb
